Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: de-mathlib Nat.binaryRec #314

Closed
wants to merge 35 commits into from

Conversation

FR-vdash-bot
Copy link
Contributor

@FR-vdash-bot FR-vdash-bot commented Oct 22, 2023

Some of the definitions have been modified to be faster.

@fgdorais fgdorais added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Oct 23, 2023
@joehendrix joehendrix added awaiting-author Waiting for PR author to address issues and removed awaiting-review This PR is ready for review; the author thinks it is ready to be merged. labels Oct 26, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Nov 1, 2023
@FR-vdash-bot
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added awaiting-review This PR is ready for review; the author thinks it is ready to be merged. and removed awaiting-author Waiting for PR author to address issues labels Nov 15, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. and removed merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. labels Nov 15, 2023
@eric-wieser
Copy link
Member

eric-wieser commented Nov 29, 2023

What's the status of this PR in respect to #366? In that PR we got:

/--
An induction principal that works on divison by two.
-/
noncomputable def div2Induction {motive : Nat → Sort u}
    (n : Nat) (ind : ∀(n : Nat), (n > 0 → motive (n/2)) → motive n) : motive n := by
  induction n using Nat.strongInductionOn with
  | ind n hyp =>
    apply ind
    intro n_pos
    if n_eq : n = 0 then
      simp [n_eq] at n_pos
    else
      apply hyp
      exact Nat.div_lt_self n_pos (Nat.le_refl _)

but these don't seem directly related.

Std/Data/Nat/Lemmas.lean Outdated Show resolved Hide resolved
Std/Data/Nat/Lemmas.lean Outdated Show resolved Hide resolved
Std/Data/Nat/Lemmas.lean Outdated Show resolved Hide resolved
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 15, 2023
@FR-vdash-bot
Copy link
Contributor Author

I'm not sure where these diffs are. It might just be some mess from the merge.

@FR-vdash-bot
Copy link
Contributor Author

What's the status of this PR in respect to #366? In that PR we got:

/--
An induction principal that works on divison by two.
-/
noncomputable def div2Induction {motive : Nat → Sort u}
    (n : Nat) (ind : ∀(n : Nat), (n > 0 → motive (n/2)) → motive n) : motive n := by
  induction n using Nat.strongInductionOn with
  | ind n hyp =>
    apply ind
    intro n_pos
    if n_eq : n = 0 then
      simp [n_eq] at n_pos
    else
      apply hyp
      exact Nat.div_lt_self n_pos (Nat.le_refl _)

but these don't seem directly related.

I replaced it with binaryRecs and did some golf.

@fgdorais
Copy link
Collaborator

Strange. Please ignore my comments then.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Jan 11, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Jan 19, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Feb 7, 2024
@FR-vdash-bot
Copy link
Contributor Author

FR-vdash-bot commented Mar 23, 2024

It seems that Std.Data.Nat.Bitwise is not there now. What should I do now? Should I create a PR for core?

@fgdorais fgdorais added duplicate This issue or pull request already exists and removed awaiting-review This PR is ready for review; the author thinks it is ready to be merged. labels Jul 23, 2024
@fgdorais
Copy link
Collaborator

Marking as duplicate while waiting for lean4#3756. Ask to remove that label if that PR doesn't get merged.

@FR-vdash-bot
Copy link
Contributor Author

Replaced by #799.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants