feat: monadic defs for statically sized vectors #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP |
Shreyas4991
commented
Aug 18, 2024
| def modifyM [Monad m] (v : Vector α n) (i : Nat) | ||
| (f : α → m α) : m (Vector α n) := do | ||
| return ⟨←Array.modifyM v.toArray i f, | ||
| by rw[←v.size_eq]; sorry⟩ |
There was a problem hiding this comment.
Any help in fixing this sorry is welcome. I found a lemma by the name Array.size_modifyM which however is not a straightforward equality.
Shreyas4991
commented
Aug 18, 2024
| -/ | ||
| def mapM {α : Type u} {β : Type v} {m : Type v → Type w} [Monad m] | ||
| (f : α → m β) (v : Vector α n) : m (Vector β n) := do | ||
| return ⟨←Array.mapM f v.toArray, by rw[←v.size_eq]; sorry⟩ |
There was a problem hiding this comment.
This sorry is also stuck for the same reason as the above comment because the corresponding Array API uses Satisfies. I am grateful for any help with these situations
Shreyas4991
commented
Aug 18, 2024
| def mapIdxM {α : Type u} {β : Type v} {m : Type v → Type w} [Monad m] | ||
| (v : Vector α n) (f : Fin n → α → m β) : m (Vector β n) := do | ||
| return ⟨←Array.mapIdxM v.toArray (v.size_eq.symm ▸ f), | ||
| by rw[←v.size_eq]; sorry⟩ |
There was a problem hiding this comment.
Another sorry that I am stuck at because the relevant API lemma uses the Satisfies predicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first follow up to #793. It adds all the monadic definitions for Vectors that correspond to similar definitions for Arrays in core and Batteries as well as defs which are immediately downstream of them. There are no plans to add theorems in this PR.
-[] Add all monadic definitions from
Init.Data.Array.Basicand their downstream definitions for Vectors.-[] Add all monadic definitions from
Batteries.Data.Array.Basicand their downstream definitions for Vectors.