Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Mersenne Twister PRNG #984

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: add Mersenne Twister PRNG #984

wants to merge 15 commits into from

Conversation

fgdorais
Copy link
Collaborator

@fgdorais fgdorais commented Oct 12, 2024 •
edited
Loading

TODO:

  • Add tests.
  • Improve docs.

The implementation is very general. Probably still reasonably efficient but we could link to an optimized external implementation for the standard MT19937 and MT19937-64 algorithms.

@fgdorais fgdorais added the WIP work in progress label Oct 12, 2024
@fgdorais fgdorais changed the title feat: add Mersenne Twister pseudorandom generator feat: add Mersenne Twister PRNG Oct 12, 2024
@digama0
Copy link
Member

digama0 commented Oct 13, 2024 •
edited
Loading

Needs a test file and/or usage example in the docs, otherwise LGTM

@fgdorais fgdorais added the depends on another PR This is stacked on top of another Batteries PR. label Oct 14, 2024
@fgdorais fgdorais added awaiting-review This PR is ready for review; the author thinks it is ready to be merged. and removed WIP work in progress labels Oct 14, 2024
@fgdorais fgdorais marked this pull request as ready for review October 14, 2024 03:40
@fgdorais fgdorais requested a review from digama0 October 14, 2024 05:15
@fgdorais
Copy link
Collaborator Author

@digama0 I think this is ready for "final" review. I added docs and tests. The update code needs a future upgrade but that needs some new BitVec features to do correctly.

leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 28, 2024
@leanprover-community-mathlib4-bot
Update Batteries branch for testing leanprover-community/batteries#984
7ae666d
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 28, 2024 •
edited
Loading

Mathlib CI status (docs):

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Nov 4, 2024
@fgdorais fgdorais removed the depends on another PR This is stacked on top of another Batteries PR. label Nov 4, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#984
a1f2d07
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#984
b773ec9
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Nov 4, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 22, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#984
350781f
@fgdorais fgdorais added the will-merge-soon PR will be merged soon. Any concerns should be raised quickly. label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0

Assignees
No one assigned
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged. builds-mathlib will-merge-soon PR will be merged soon. Any concerns should be raised quickly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fgdorais @digama0 @leanprover-community-bot @leanprover-community-mathlib4-bot