Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: npow / nsmul / Nat.cast/ zpow / zsmul implemented using Nat.binaryRec #9154

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

feat: npow / nsmul / Nat.cast/ zpow / zsmul implemented using Nat.binaryRec #9154

wants to merge 26 commits into from

Conversation

FR-vdash-bot
Copy link
Collaborator

@FR-vdash-bot FR-vdash-bot commented Dec 20, 2023 •
edited
Loading

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Dec 20, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Dec 20, 2023 •
edited
Loading

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 20, 2023
@eric-wieser
Copy link
Member

This overlaps with #8885 (cc @semorrison), right? I think we found that binaryRec was unsuitable as it cannot be tail-recursive.

@FR-vdash-bot
Copy link
Collaborator Author

I'm not sure what Lean4 did, but the implementation in this PR passes the tests in #8885.

@eric-wieser eric-wieser mentioned this pull request Dec 27, 2023
Closed
1 task
@kim-em
Copy link
Contributor

kim-em commented Jan 15, 2024

Could you resolve the conflicts here?

I couldn't find the test from #8885 here: could you include it?

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jan 20, 2024
@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jan 31, 2024
@kim-em
Copy link
Contributor

kim-em commented Mar 5, 2024

Any progress on this? It would be great to get repeated squaring in.

@eric-wieser
Copy link
Member

Is the dependency on an Std bump necessary here?

@FR-vdash-bot
Copy link
Collaborator Author

Sorry for delay. I've been very busy these past few months. I have used @[csimp] and added the test just now. But I found out that the files involved in my std PR were moved to core and I'm not sure what I should do now.

@grunweg grunweg added the t-algebra Algebra (groups, rings, fields, etc) label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-author A reviewer has asked the author a question or requested changes blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FR-vdash-bot @leanprover-community-mathlib4-bot @eric-wieser @kim-em @grunweg @YaelDillies