Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing the new async client #159

Merged
merged 5 commits into from
May 11, 2024
Merged

Testing the new async client #159

merged 5 commits into from
May 11, 2024

Conversation

jbusecke
Copy link
Collaborator

@jbusecke jbusecke commented May 11, 2024

I actually f'ed up before and pushed to main. I cancelled the action and am just adding this PR so I can convince myself that things run smoothly in the end-to-end scenario.

Overall the new async client seems to work well and fast! We are now searching/combining results from multiple index nodes. Check across data nodes and dataset metadata that we have all files (to avoid #53 in the future), and we have all the metadata in the world to retest datasets afterwards ( #154).

As far as I am concerned, if we cannot fix an issue with the entire API response and the data, it is out of our responsibility.

Those changes will address the following issues:

@jbusecke jbusecke merged commit c0ace36 into main May 11, 2024
4 checks passed
@jbusecke jbusecke deleted the new-async-client branch May 11, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we track some of the pangeo-forge-esgf parameters into the written store?
1 participant