Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually f'ed up before and pushed to main. I cancelled the action and am just adding this PR so I can convince myself that things run smoothly in the end-to-end scenario.
Overall the new async client seems to work well and fast! We are now searching/combining results from multiple index nodes. Check across data nodes and dataset metadata that we have all files (to avoid #53 in the future), and we have all the metadata in the world to retest datasets afterwards ( #154).
As far as I am concerned, if we cannot fix an issue with the entire API response and the data, it is out of our responsibility.
Those changes will address the following issues:
AttributeInjection
Stage earlier)