Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dependency for the albert example #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix dependency for the albert example #611

wants to merge 1 commit into from

Conversation

samsja
Copy link
Contributor

@samsja samsja commented May 13, 2024 •
edited
Loading

Context

this is just a small PR to fix some dependencies with the albert example. The old version of dataset and wandb being not compatible with the current hf and wandb hub

@samsja samsja force-pushed the fix-albert-example branch from 4404258 to ef1dbdc Compare May 13, 2024 12:19
@samsja
Copy link
Contributor Author

samsja commented May 13, 2024 •
edited
Loading

it seems that the CI is failing for an error linked to this issue : #610

EDIT: CI problem Should be fixed by this PR : #612

@mryab
Copy link
Member

mryab commented Jun 9, 2024

@samsja Thanks for the PR! The fix for CI is merged to master, can you rebase your branch on it and try again?

Also, can you please confirm that the script works with these dependencies updated?

@samsja
Copy link
Contributor Author

samsja commented Jun 10, 2024 •
edited
Loading

@samsja Thanks for the PR! The fix for CI is merged to master, can you rebase your branch on it and try again?

Also, can you please confirm that the script works with these dependencies updated?

yes the script is now working with this dependency. I just rebased the branch

@samsja samsja force-pushed the fix-albert-example branch from ef1dbdc to 3dcd369 Compare June 10, 2024 07:17
@samsja samsja mentioned this pull request Jun 13, 2024
Merged
@mryab
Copy link
Member

mryab commented Jul 13, 2024

@samsja Could you please rebase the branch again? GitHub shows that it's not possible for me to resolve the conflict automatically, and I can't rerun the tests while there's a conflict

@JohannesHa @samsja
fixed dependencies albert example
3372e2b 
fixed requirements for albert example

fix dataset versions (learning-at-home#1)

Revert "fixed albert example"

This reverts commit cccce0c.

remove accelerate
@samsja samsja force-pushed the fix-albert-example branch from 3dcd369 to 3372e2b Compare July 16, 2024 07:33
@samsja
Copy link
Contributor Author

samsja commented Jul 16, 2024

@samsja Could you please rebase the branch again? GitHub shows that it's not possible for me to resolve the conflict automatically, and I can't rerun the tests while there's a conflict

it should be fine now, I rebased on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsja @mryab @JohannesHa