Skip to content

Commit

Permalink
cleaned up according to cbf (not use todo but enhancement)
Browse files Browse the repository at this point in the history
  • Loading branch information
NinaHerrmann committed Jun 11, 2024
1 parent 568383e commit e8717cf
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion classes/local/backup/restore_lifecycle_workflow.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function execute(bool $force = false) {
$this->check_subplugin_validity();
if (empty($this->errors) || $force) {
// If all loaded data is valid, the new workflow and the steps can be stored in the database.
// If we force the import, we empty the errors;
// If we force the import, we empty the errors.
$this->errors = [];
$this->persist();
}
Expand Down
2 changes: 1 addition & 1 deletion classes/local/manager/interaction_manager.php
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ public static function get_process_status_message($processid) {
}

if ($process->stepindex == 0) {
// TODO: Rethink behaviour for multiple triggers.
// Software enhancement: Rethink behaviour for multiple triggers.
$trigger = trigger_manager::get_triggers_for_workflow($process->workflowid)[0];
$triggerlib = lib_manager::get_trigger_lib($trigger->subpluginname);
return $triggerlib->get_status_message();
Expand Down
2 changes: 1 addition & 1 deletion classes/local/manager/workflow_manager.php
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ public static function activate_workflow($workflowid) {
$transaction = $DB->start_delegated_transaction();
$workflow = self::get_workflow($workflowid);
if (!self::is_active($workflow->id)) {
// TODO: Rethink behaviour for multiple triggers.
// Software enhancement: Rethink behaviour for multiple triggers.
$trigger = trigger_manager::get_triggers_for_workflow($workflowid)[0];
$lib = lib_manager::get_trigger_lib($trigger->subpluginname);
$workflow->manual = $lib->is_manual_trigger();
Expand Down
4 changes: 2 additions & 2 deletions classes/view_controller.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function handle_view($renderer, $filterdata) {
$courses = get_user_capability_course('tool/lifecycle:managecourses', null, false);
if (!$courses) {
echo 'no courses';
// TODO show error.
// Software enhancement show error.
return;
}

Expand Down Expand Up @@ -142,7 +142,7 @@ public function handle_interaction($action, $processid, $stepid) {
*/
public function handle_trigger($triggerid, $courseid) {
global $PAGE;
// TODO check if trigger to triggerid exists.
// Software enhancement check if trigger to triggerid exists.
// Check if trigger is manual.
$trigger = trigger_manager::get_instance($triggerid);
$lib = lib_manager::get_trigger_lib($trigger->subpluginname);
Expand Down
2 changes: 1 addition & 1 deletion step/email/interactionlib.php
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public function get_due_date($processid, $stepid) {
$date += $settings['responsetimeout'];
}
}
// TODO default format -- seconds -> not in this class !
// Software enhancement default format -- seconds -> not in this class !
return date('d.m.Y', $date);
}

Expand Down
2 changes: 1 addition & 1 deletion step/email/lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public function post_processing_bulk_operation() {
$subject = $parsedsettings['subject'];
$content = $parsedsettings['content'];
$contenthtml = $parsedsettings['contenthtml'];
// TODO: use course info to parse content template!
// Software enhancement: use course info to parse content template!
email_to_user($user, \core_user::get_noreply_user(), $subject, $content, $contenthtml);
$DB->delete_records('lifecyclestep_email',
['instanceid' => $step->id,
Expand Down

0 comments on commit e8717cf

Please sign in to comment.