Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config yaml schema support #304

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Add config yaml schema support #304

wants to merge 7 commits into from

Conversation

lebrice
Copy link
Owner

@lebrice lebrice commented Feb 7, 2024

Fixes #288

TODOs:

  • Figure out how to best make this available to the user.

Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
@lebrice lebrice changed the title Add yaml schema support Add config yaml schema support Feb 7, 2024
Signed-off-by: Fabrice Normandin <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (3194331) 86.44% compared to head (cf5f9a9) 84.55%.

❗ Current head cf5f9a9 differs from pull request most recent head b0c4071. Consider uploading reports for the commit b0c4071 to get more accurate results

Files Patch % Lines
...imple_parsing/helpers/serialization/yaml_schema.py 20.74% 107 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   86.44%   84.55%   -1.90%     
==========================================
  Files          34       35       +1     
  Lines        4531     4668     +137     
==========================================
+ Hits         3917     3947      +30     
- Misses        614      721     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export args to a schema file so that YAML language servers can understand config files
2 participants