Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JsonDB lazyness #42

Merged
merged 16 commits into from
Dec 21, 2023
Merged

Fix JsonDB lazyness #42

merged 16 commits into from
Dec 21, 2023

Conversation

gipert
Copy link
Member

@gipert gipert commented Dec 10, 2023

No description provided.

@gipert gipert added bug Something isn't working enhancement New feature or request labels Dec 10, 2023
@gipert gipert linked an issue Dec 10, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (2b41a77) 74.56% compared to head (93703c5) 72.45%.

Files Patch % Lines
src/legendmeta/jsondb.py 79.06% 18 Missing ⚠️
src/legendmeta/slowcontrol.py 18.18% 18 Missing ⚠️
src/legendmeta/police.py 34.78% 15 Missing ⚠️
src/legendmeta/catalog.py 41.66% 14 Missing ⚠️
src/legendmeta/core.py 50.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   74.56%   72.45%   -2.11%     
==========================================
  Files           7        7              
  Lines         684      737      +53     
==========================================
+ Hits          510      534      +24     
- Misses        174      203      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert marked this pull request as draft December 11, 2023 17:09
Default is JsonDB(..., lazy="auto"), which means that the constructor
tries to determine if code is ran interactively (then lazy=False).
@gipert gipert marked this pull request as ready for review December 21, 2023 13:25
@gipert gipert merged commit 3930775 into main Dec 21, 2023
12 checks passed
@gipert gipert deleted the fix branch December 21, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve laziness
1 participant