Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add option to set output file, type converter for log level #64

Merged
merged 11 commits into from
Apr 3, 2024

Conversation

ManuelHu
Copy link
Collaborator

@ManuelHu ManuelHu commented Apr 1, 2024

This is already possible in a macro file, but I would find it useful to be able to set this also with the cli parameters. (i.e. for GDML files, both ways are also valid)

@ManuelHu
Copy link
Collaborator Author

ManuelHu commented Apr 1, 2024

Note that this is particularly ugly, but the ordering of the CLI11 include after the namespaced defintion of the converter function is necessary. Otherwise it would not be picked up by CLI11...

another note: Having three options to control log verbosity (-v to increase, -q to decrease, and -l to set it directly) seems like overkill to me.

@ManuelHu ManuelHu changed the title cli: add option to set output file cli: add option to set output file, type converter for log level Apr 1, 2024
@ManuelHu ManuelHu merged commit 9b9aec8 into legend-exp:main Apr 3, 2024
5 checks passed
@ManuelHu ManuelHu deleted the cli-output branch April 3, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant