Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output time of vertex duration in run statistics #73

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

ManuelHu
Copy link
Collaborator

@ManuelHu ManuelHu commented Apr 22, 2024

  • Outstanding question: Should we include the time of the first event geometry initialization in the statistics? Currently it is included in the time of the first vertex generation, which significantly skews the statistics for the first run...
  • This also reset the trial counter (and now the generation time) before each new run, so that it does not monotonically increase which each run (as it did until now)

Other changes:

  • Fixes allowed states for all confinement commands
  • Validate parameters for geometrical solids (solid types, all parameters). Now one cannot modify a box as a cylinder :-)
  • Move geometrical solid type from string to an enum (the strings did not match G4 names anyway)
  • Add a command to reset the vertex confinement parameters. This should allow to reset+reconfigure confinement between runs

fixes #48

@ManuelHu ManuelHu marked this pull request as draft April 22, 2024 09:06
@ManuelHu ManuelHu marked this pull request as ready for review April 22, 2024 18:31
@ManuelHu ManuelHu merged commit 4375f68 into legend-exp:main Apr 24, 2024
6 checks passed
@ManuelHu ManuelHu deleted the vertex-time branch April 24, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run summary statistics should report both time for sampling vertex and for actual simulation
1 participant