Skip to content

Commit

Permalink
BREAKING: Update minimum Node.js version to 16
Browse files Browse the repository at this point in the history
Required by update of `@metamask/json-rpc-engine` (MetaMask#16)
  • Loading branch information
legobeat committed Jul 27, 2023
1 parent cbdff52 commit fea7493
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 9 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build-lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- prepare
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 19.x]
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -49,7 +49,7 @@ jobs:
- prepare
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 19.x]
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
- prepare
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 19.x]
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
v18
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ See our documentation:

### Setup

- Install [Node.js](https://nodejs.org) version 14
- Install [Node.js](https://nodejs.org) version 18
- If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm use` will automatically choose the right node version for you.
- Install [Yarn v3](https://yarnpkg.com/getting-started/install)
- Run `yarn install` to install dependencies and run any required post-install scripts
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@metamask/eslint-config-nodejs": "^11.0.1",
"@metamask/eslint-config-typescript": "^11.0.0",
"@types/jest": "^28.1.6",
"@types/node": "^17.0.23",
"@types/node": "^16.18.39",
"@typescript-eslint/eslint-plugin": "^5.43.0",
"@typescript-eslint/parser": "^5.43.0",
"depcheck": "^1.4.3",
Expand All @@ -60,7 +60,7 @@
},
"packageManager": "[email protected]",
"engines": {
"node": ">=14.0.0"
"node": "^16.20 || ^18.16 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
11 changes: 9 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ __metadata:
"@metamask/safe-event-emitter": ^3.0.0
"@metamask/utils": ^5.0.1
"@types/jest": ^28.1.6
"@types/node": ^17.0.23
"@types/node": ^16.18.39
"@typescript-eslint/eslint-plugin": ^5.43.0
"@typescript-eslint/parser": ^5.43.0
depcheck: ^1.4.3
Expand Down Expand Up @@ -1345,13 +1345,20 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:*, @types/node@npm:^17.0.23":
"@types/node@npm:*":
version: 17.0.23
resolution: "@types/node@npm:17.0.23"
checksum: a3517554737cbb042e76c30d0e5482192ac4d9bea0eeb086e2622d9cabf460a0eb52a696b99fcd18e7fcc93c96db6cc7ae507f6608f256ef0b5c1d8c87a5a470
languageName: node
linkType: hard

"@types/node@npm:^16.18.39":
version: 16.18.39
resolution: "@types/node@npm:16.18.39"
checksum: eac9b202b76013256cb517ca8d3e3f61df206edb1615ca8d8df4c80616e92879fe4d3f8570a11d60f4216a82724a3265d5888b24c6994c80b057a0423c9ff1d2
languageName: node
linkType: hard

"@types/parse-json@npm:^4.0.0":
version: 4.0.0
resolution: "@types/parse-json@npm:4.0.0"
Expand Down

0 comments on commit fea7493

Please sign in to comment.