Skip to content

Commit

Permalink
Drop support for Node.js 14 and 16 (#443)
Browse files Browse the repository at this point in the history
* Drop support for Node.js 14 and 16

* Update README references
  • Loading branch information
jonathansamines authored Jun 18, 2024
1 parent ef59034 commit 67ef817
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
24 changes: 12 additions & 12 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,24 @@ on:
push:
branches: [master, develop]
pull_request:
branches: ['*']
branches: ["*"]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [18.x, 20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm test
- run: npx @pkgjs/support validate
env:
CI: true
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm test
- run: npx @pkgjs/support validate
env:
CI: true
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
| Version | Node support |
|----------------------------------------------------------------------------------|---------------------|
| [5.x](https://github.com/lelylan/simple-oauth2/tree/5.x) | Node 14.x or higher |
| [6.x (Development)](https://github.com/lelylan/simple-oauth2/tree/master) | Node 16.x or higher |
| [6.x (Development)](https://github.com/lelylan/simple-oauth2/tree/master) | Node 18.x or higher |

Older node versions are unsupported.

Expand Down Expand Up @@ -81,7 +81,7 @@ async function run() {
redirect_uri: 'http://localhost:3000/callback',
scope: '<scope>',
state: '<state>',

customParam: 'foo', // non-standard oauth params may be passed as well
});

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"url": "https://github.com/lelylan/simple-oauth2"
},
"engine": {
"node": ">=14"
"node": ">=18"
},
"scripts": {
"pretest": "npm run lint",
Expand Down Expand Up @@ -65,6 +65,6 @@
"nock": "^13.2.9"
},
"volta": {
"node": "16.13.1"
"node": "18.20.3"
}
}

0 comments on commit 67ef817

Please sign in to comment.