Fix potential null value issue in MergeDefaultConfig (#29)

* Fix potential null value issue in MergeDefaultConfig * 🔧 Simplify default config value assignment Simplify the assignment of default configuration values by removing unnecessary conditional checks. This change improves code readability and reduces complexity. --------- Co-authored-by: Lee Miller <[email protected]>
lemillermicrosoft · Oct 19, 2023 · deed85c · deed85c
1 parent 591e2d1
commit deed85c
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/apps/SKonsole/ConfigurationProvider.cs b/apps/SKonsole/ConfigurationProvider.cs
@@ -35,10 +35,9 @@ private void MergeDefaultConfig()
         };
 
         bool hasChanged = false;
-
         foreach (var defaultConfigItem in defaultConfig)
         {
-            if (string.IsNullOrWhiteSpace(this._config[defaultConfigItem.Key]))
+            if (!this._config.TryGetValue(defaultConfigItem.Key, out string? value) || string.IsNullOrWhiteSpace(value))
             {
                 this._config[defaultConfigItem.Key] = defaultConfigItem.Value;
                 hasChanged = true;