#24 Handle model binding routes in if_route_param

src/Active.php

@@ -2,6 +2,7 @@
 
 namespace HieuLe\Active;
 
+use Illuminate\Database\Eloquent\Model;
 use Illuminate\Http\Request;
 use Illuminate\Routing\Route;
 use Illuminate\Support\Str;
@@ -250,7 +251,15 @@ public function checkRouteParam($param, $value)
             return false;
         }
 
-        return $this->route->parameter($param) == $value;
+        $paramValue = $this->route->parameter($param);
+
+        // If the parameter value is an instance of Model class, we compare $value with the value of
+        // its primary key.
+        if (is_a($paramValue, Model::class)) {
+            return $paramValue->{$paramValue->getKeyName()} == $value;
+        }
+
+        return $paramValue == $value;
     }
 
     /**

tests/ActiveTest.php

@@ -26,6 +26,10 @@ public function setUp()
             ]);
             app('router')->get('/', function () {
             });
+            app('router')->bind('model', function ($id) {
+                return new StubModel(['uid' => $id]);
+            });
+            app('router')->get('/model/{model}', '\HieuLe\ActiveTest\Http\DumpController@viewMethod');
         });
     }
 
@@ -118,7 +122,8 @@ public function testCheckCurrentAction(Request $request, $actions, $result)
 
     /**
      * @param Request $request
-     * @param         $controllers
+     * @param
+     *        $controllers
      * @param         $result
      *
      * @dataProvider provideCheckControllerTestData
@@ -378,6 +383,18 @@ public function provideCheckRouteParameterTestData()
                 '2',
                 false,
             ],
+            'match a route bound to a model' => [
+                Request::create('/model/100'),
+                'model',
+                '100',
+                true,
+            ],
+            'not match a route bound to another model' => [
+                Request::create('/model/100'),
+                'model',
+                '1',
+                false,
+            ],
         ];
     }
 

tests/StubModel.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace HieuLe\ActiveTest;
+
+
+use Illuminate\Database\Eloquent\Model;
+
+class StubModel extends Model
+{
+    protected $fillable = ['id', 'uid'];
+    protected $primaryKey = 'uid';
+}