Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text highlight and selection by cursor on top of annotations #66

Merged
merged 12 commits into from
Aug 30, 2024

Conversation

lfoppiano
Copy link
Owner

This PR improves the selection on top of annotations, currently the annotation boxes were impeding the cursor to change to selection and they were making the selection not user friendly.

With this PR we rearrange the layers by placing the annotations at z-index=1 and and the text layer div at z-index=2. In this way everything is visible and the text takes priority over the annotations.

@lfoppiano
Copy link
Owner Author

Problem partially solved, however, in general there is a clumsiness in selecting text.
Trying to ask for help at the pdf.js github discusssion panel.

@lfoppiano lfoppiano marked this pull request as ready for review August 20, 2024 05:44
@lfoppiano lfoppiano requested a review from t29mato August 20, 2024 05:44
@lfoppiano lfoppiano changed the title Enable selection on top of annotations Improve text highlight and selection by cursor on top of annotations Aug 23, 2024
@lfoppiano lfoppiano merged commit 76e37fb into main Aug 30, 2024
15 checks passed
@lfoppiano lfoppiano deleted the revise-textlayers branch August 30, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant