Add crossorigin attribute to Link header for scripts with type=module #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cosmic-bubblegum-aa631a canceled.
|
andyexeter
force-pushed
the
15-crossorigin-attribute-on-module-link-headers
branch
from
4ea2024
to
2a4cfa1
Compare
|
I've updated the PR to use the value of the Btw @lhapaipai, I noticed the CI workflow for the bundle is only running on PHP 8.2: I think we should update this to run on all supported versions. |
|
thank you very much @andyexeter for your valuable suggestions ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15
This PR stores the tag object for each rendered script in the rendered scripts array so the
typeattribute can be checked in thePreloadAssetsEventListener.If the
typeismodule, we add thecrossoriginattribute to the Link header.