websocket_frame_parser: Initialize m_error_desc to a null pointer

lhmouse · Jan 15, 2024 · 12ca074 · 12ca074
1 parent f38fc8d
commit 12ca074
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/poseidon/http/websocket_frame_parser.cpp b/poseidon/http/websocket_frame_parser.cpp
@@ -167,7 +167,7 @@ clear() noexcept
     this->m_frm_payload_rem = 0;
 
     this->m_state_stor = 0;
-    this->m_error_desc = "";
+    this->m_error_desc = nullptr;
   }
 
 void
@@ -322,7 +322,7 @@ accept_handshake_request(HTTP_Response_Headers& resp, const HTTP_Request_Headers
     // For the server, this connection has now been established.
     this->m_wshs = wshs_s_accepted;
     this->m_wsf = wsf_new;
-    this->m_error_desc = "";
+    this->m_error_desc = nullptr;
   }
 
 void
@@ -413,7 +413,7 @@ accept_handshake_response(const HTTP_Response_Headers& resp)
     // For the client, this connection has now been established.
     this->m_wshs = wshs_c_accepted;
     this->m_wsf = wsf_new;
-    this->m_error_desc = "";
+    this->m_error_desc = nullptr;
   }
 
 void

diff --git a/poseidon/http/websocket_frame_parser.hpp b/poseidon/http/websocket_frame_parser.hpp
@@ -54,10 +54,11 @@ class WebSocket_Frame_Parser
       };
     };
 
-    const char* m_error_desc = "";
+    const char* m_error_desc = nullptr;
 
   public:
     // Constructs a parser for incoming frames.
+    constexpr
     WebSocket_Frame_Parser() noexcept
       { }
 
@@ -71,7 +72,7 @@ class WebSocket_Frame_Parser
 
     const char*
     error_description() const noexcept
-      { return this->m_error_desc;  }
+      { return this->m_error_desc ? this->m_error_desc : "success";  }
 
     // Get the operating mode.
     bool