Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run testCoreformGeom unit tests if PETSc is enabled and new enough #3804

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

jwpeterson
Copy link
Member

Refs #3803

@roystgnr
Copy link
Member

Looks like we're missing the header that includes that macro? (although we're getting it indirectly under most builds)

@roystgnr
Copy link
Member

Thanks for catching this, and IMHO this is the right fix. This is new enough stuff that I don't care about supporting runtime incompatibilities with old PETSc.

@jwpeterson
Copy link
Member Author

Any idea what's going on with the failing MOOSE tests?

   ERROR misc/signal_handler.test_signal_parallel_recover FAILED (unknown dependency) [min_cpus=3]
   ERROR misc/signal_handler.test_signal_recover_debug FAILED (unknown dependency) [METHOD!=DBG]
   ERROR misc/signal_handler.test_signal_recover FAILED (unknown dependency)

@roystgnr
Copy link
Member

I can't find any obvious recent changes. I'll ask around. Definitely nothing related to this PR though.

@roystgnr
Copy link
Member

Wait, I think I know what MOOSE PR would have triggered this.

@roystgnr
Copy link
Member

idaholab/moose#26588 went in 5 days ago; I'm betting that's the one.

@jwpeterson
Copy link
Member Author

The remaining failures all seem to be unrelated to this change so I will merge now.

@jwpeterson jwpeterson merged commit 0c5dbe6 into libMesh:devel Mar 19, 2024
17 of 21 checks passed
@jwpeterson jwpeterson deleted the disable_unit_test_old_petsc branch March 19, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants