Merge pull request #999 from libp2p/fix/context-from-996

fix(crawler): separate timeout per query
libp2p · Nov 15, 2024 · ace7582 · ace7582
2 parents f671a50 + 02e9c54
commit ace7582
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/crawler/crawler.go b/crawler/crawler.go
@@ -147,10 +147,10 @@ func (c *DefaultCrawler) Run(ctx context.Context, startingPeers []*peer.AddrInfo
 	for i := 0; i < c.parallelism; i++ {
 		go func() {
 			defer wg.Done()
-			ctx, cancel := context.WithTimeout(ctx, c.queryTimeout)
-			defer cancel()
 			for p := range jobs {
-				res := c.queryPeer(ctx, p)
+				qctx, cancel := context.WithTimeout(ctx, c.queryTimeout)
+				res := c.queryPeer(qctx, p)
+				cancel() // do not defer, cleanup after each job
 				results <- res
 			}
 		}()