Gossip: more reliable publishing #387
Open
+98
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't find the definition of "direct peer" in the spec, but per my mental model two direct peers mutually configured as "direct peer" always exchange messages among each other. Then I also wonder why direct peers are blindly considered for outbound even if they don't subscribe to the specific topic (but this is another question :-), and maybe it's fine) |
StefanBratanov
approved these changes
Oct 21, 2024
| if (topicMeshPeers != null) { | ||
| // we are subscribed to the topic | ||
| val addFromNonMeshCount = max(0, params.D - topicMeshPeers.size) | ||
| val nonMeshTopicPeers = (getTopicPeers(topic) - topicMeshPeers) |
There was a problem hiding this comment.
Nit: no need of the brackets
| if (topicMeshPeers != null) { | ||
| // we are subscribed to the topic | ||
| val addFromNonMeshCount = max(0, params.D - topicMeshPeers.size) | ||
| val nonMeshTopicPeers = (getTopicPeers(topic) - topicMeshPeers) |
There was a problem hiding this comment.
Do we care about the score of the topic peers in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quote from the Gossip spec:
According to spec we should forward the message we are publishing to the mesh peers only.
However the mesh could be not that stable (for example a peer may be evicted from mesh due to slight gossip downscorring (any score
<0)). Thus it could lead to the situation, when the mesh is empty but there are still peers subscribed to the topic outside of the mesh. According to the spec we are not able to publish.The situation could not be that dramatic due to
IHAVE/IWANTmechanism which should finally make the message published, but that could induce significant publish latency.To overcome this it does make sense to take extra peers outside of the mesh when the mesh size is
< D.This is also the subject for a PR to the Gossip spec