Skip to content

Commit

Permalink
feat(interop-tests): add ability to run chromedriver tests on Windows
Browse files Browse the repository at this point in the history
When running on Windows OS, the command needs the `.cmd` extension in order to work.

Pull-Request: #4456.
  • Loading branch information
DougAnderson444 authored Sep 5, 2023
1 parent b108c68 commit 6f0895f
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion interop-tests/src/bin/wasm_ping.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,12 @@ async fn open_in_browser() -> Result<(Child, WebDriver)> {
// start a webdriver process
// currently only the chromedriver is supported as firefox doesn't
// have support yet for the certhashes
let mut chrome = tokio::process::Command::new("chromedriver")
let chromedriver = if cfg!(windows) {
"chromedriver.cmd"
} else {
"chromedriver"
};
let mut chrome = tokio::process::Command::new(chromedriver)
.arg("--port=45782")
.stdout(Stdio::piped())
.spawn()?;
Expand Down

0 comments on commit 6f0895f

Please sign in to comment.