-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use if-watch-plus instead of if-watch #5624
base: master
Are you sure you want to change the base?
chore: use if-watch-plus instead of if-watch #5624
Conversation
Thanks for the PR! Can you update the workspace |
…m:RawinSader/rust-libp2p into rawi/ios-cross-compilation-dependency-fix
Update me if there is anything else I forgot to do :) |
Hi, in the rust-libp2p community call I remarked that it was strange that |
This pull request has merge conflicts. Could you please resolve them @RawinSader? 🙏 |
Since if-watch was moved to llibp2p org, this issue could be closed now no? CC @jxs |
Description
Libp2p relies on a package called
[email protected]
in 4 different places:transport/tcp
transport/quic
transport/webrtc
protocol/mdns
This unmaintained library uses a deprecate iOS interface through one of its own dependencies `[email protected]:
Seeing that our bindings use this deprecated interface, iOS apps will fail to build for everyone using
rust-libp2p
.Notes & open questions
if-watch
that only updates thesystem-configurations
dependency to the latest version that addresses the deprecated interfacesystem-configurations
Change checklist