Hotfix mesh map (#448)

* chore(mesh-wide): prevent empty objects * chore(mesh-wide): prevent undefined * chore(mesh-wide): improve isEmpty
libremesh · Sep 4, 2024 · 75c87fc · 75c87fc
1 parent 03cdeaf
commit 75c87fc
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/plugins/lime-plugin-mesh-wide/src/lib/links/getLinksCoordinates.ts b/plugins/lime-plugin-mesh-wide/src/lib/links/getLinksCoordinates.ts
@@ -34,11 +34,15 @@ export const mergeLinksAndCoordinates = <T extends LinkType>(
             // Find destination link info from shared state
             let dest: IBaseLink<T>;
             for (const destNodeKey in links) {
-                const link = Object.entries(links[destNodeKey].links).find(
-                    ([key]) => key === linkKey && destNodeKey !== actualNodeName
-                );
-                if (link) {
-                    dest = { [destNodeKey]: link[1] };
+                // Prevent empty objects crashing from shared state
+                if (links[destNodeKey] && !isEmpty(links[destNodeKey]?.links)) {
+                    const link = Object.entries(links[destNodeKey].links).find(
+                        ([key]) =>
+                            key === linkKey && destNodeKey !== actualNodeName
+                    );
+                    if (link) {
+                        dest = { [destNodeKey]: link[1] };
+                    }
                 }
             }
 

diff --git a/src/utils/utils.tsx b/src/utils/utils.tsx
@@ -1,3 +1,8 @@
-export function isEmpty(obj: object): boolean {
+export function isEmpty(obj: object | null | undefined): boolean {
+    // Check if the input is null, undefined, or not an object
+    if (obj == null || typeof obj !== "object") {
+        return true;
+    }
+    // Return true if the object has no own properties
     return Object.keys(obj).length === 0;
 }