Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix mesh map #448

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Hotfix mesh map #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9f4242
chore(mesh-wide): prevent empty objects
selankon Sep 4, 2024
09c4559
chore(mesh-wide): prevent undefined
selankon Sep 4, 2024
4af5627
chore(mesh-wide): improve isEmpty
selankon Sep 4, 2024
5d12601
chore(mesh-wide): chore
selankon Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions plugins/lime-plugin-mesh-wide/src/lib/links/getLinksCoordinates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,15 @@ export const mergeLinksAndCoordinates = <T extends LinkType>(
// Find destination link info from shared state
let dest: IBaseLink<T>;
for (const destNodeKey in links) {
const link = Object.entries(links[destNodeKey].links).find(
([key]) => key === linkKey && destNodeKey !== actualNodeName
);
if (link) {
dest = { [destNodeKey]: link[1] };
// Prevent empty objects crashing from shared state
if (links[destNodeKey] && !isEmpty(links[destNodeKey]?.links)) {
const link = Object.entries(links[destNodeKey].links).find(
([key]) =>
key === linkKey && destNodeKey !== actualNodeName
);
if (link) {
dest = { [destNodeKey]: link[1] };
}
}
}

Expand Down
7 changes: 6 additions & 1 deletion src/utils/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
export function isEmpty(obj: object): boolean {
export function isEmpty(obj: object | null | undefined): boolean {
// Check if the input is null, undefined, or not an object
if (obj == null || typeof obj !== "object") {
return true;
}
// Return true if the object has no own properties
return Object.keys(obj).length === 0;
}