feat: support abstract collections #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJCampi
force-pushed
the
feat-support-abstract-collections
branch
from
4c6ab39
to
7e19a59
Compare
|
Hey @george-zubrienko, |
|
Hey @PJCampi! I'll do it in the evening today - thanks a lot for keeping things in check! |
george-zubrienko
previously approved these changes
Jun 5, 2024
PJCampi
force-pushed
the
feat-support-abstract-collections
branch
from
5927478
to
2d0cd4f
Compare
george-zubrienko
approved these changes
Jun 5, 2024
|
@PJCampi released in 0.6.7 |
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Jun 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dataclasses-json](https://togithub.com/lidatong/dataclasses-json) ([changelog](https://togithub.com/lidatong/dataclasses-json/releases)) | `0.6.6` -> `0.6.7` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>lidatong/dataclasses-json (dataclasses-json)</summary> ### [`v0.6.7`](https://togithub.com/lidatong/dataclasses-json/releases/tag/v0.6.7) [Compare Source](https://togithub.com/lidatong/dataclasses-json/compare/v0.6.6...v0.6.7) #### What's Changed - feat: support abstract collections by [@​PJCampi](https://togithub.com/PJCampi) in [https://github.com/lidatong/dataclasses-json/pull/532](https://togithub.com/lidatong/dataclasses-json/pull/532) - Warn about buggy type resolution by [@​DavidCain](https://togithub.com/DavidCain) in [https://github.com/lidatong/dataclasses-json/pull/529](https://togithub.com/lidatong/dataclasses-json/pull/529) #### New Contributors - [@​DavidCain](https://togithub.com/DavidCain) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/529](https://togithub.com/lidatong/dataclasses-json/pull/529) **Full Changelog**: lidatong/dataclasses-json@v0.6.6...v0.6.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZTpkZXBlbmRlbmNpZXMiXX0=--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing with abstract collections rather than concrete implementations typically make for a looser and contract based API.
This PR implements decoding to an abstract collections by selecting an implementation that conforms to the abstraction.