Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking Router + CSM #78

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

Staking Router + CSM #78

wants to merge 29 commits into from

Conversation

avsetsin
Copy link

No description provided.

krogla and others added 28 commits April 15, 2024 19:04
* feat: deploy script

* feat: acceptance deploy script
…-improvements

Deploy script for updateTargetValidatorLimits
…nto feature/extra-nor-factories-vebo-improvements
…nto feature/extra-nor-factories-vebo-improvements
@bulbozaur
Copy link
Contributor

Screenshot 2024-10-15 at 11 15 18
There are errors in tests

@avsetsin
Copy link
Author

@bulbozaur, thanks for pointing that out! The tests are indeed crashing and this is expected behavior. The update changes the signature of the addStakingModule method, adding new arguments to it. Tests do not pass on the current protocol state, but pass on the state after the protocol update. Pls, use the voting script from this PR lidofinance/scripts#230 to run and execute upgrade vote on fork and try to run tests after it's executed.

Copy link
Contributor

@bulbozaur bulbozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants