feat: small fixed in SRModulesLeysController and e2e tests

lidofinance · Sep 18, 2023 · 758a2d2 · 758a2d2
1 parent 6c82b4a
commit 758a2d2
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 9 deletions.
diff --git a/src/http/sr-modules-keys/sr-modules-keys.controller.ts b/src/http/sr-modules-keys/sr-modules-keys.controller.ts
@@ -1,4 +1,16 @@
-import { Controller, Get, Version, Param, Query, Body, Post, NotFoundException, HttpStatus, Res } from '@nestjs/common';
+import {
+  Controller,
+  Get,
+  Version,
+  Param,
+  Query,
+  Body,
+  Post,
+  NotFoundException,
+  HttpStatus,
+  Res,
+  HttpCode,
+} from '@nestjs/common';
 import { ApiNotFoundResponse, ApiOperation, ApiParam, ApiResponse, ApiTags } from '@nestjs/swagger';
 import { SRModuleKeyListResponse, GroupedByModuleKeyListResponse } from './entities';
 import { SRModulesKeysService } from './sr-modules-keys.service';
@@ -86,6 +98,7 @@ export class SRModulesKeysController {
 
   @Version('1')
   @Post(':module_id/keys/find')
+  @HttpCode(HttpStatus.OK)
   @ApiOperation({ summary: 'Get list of found staking router module keys in db from pubkey list.' })
   @ApiResponse({
     status: 200,

diff --git a/src/http/sr-modules-keys/sr-modules-keys.e2e-spec.ts b/src/http/sr-modules-keys/sr-modules-keys.e2e-spec.ts
@@ -125,7 +125,6 @@ describe('SRModulesKeysController (e2e)', () => {
       });
 
       it('Should return all keys for request without filters', async () => {
-        // Get all keys and operators without filters
         const resp = await request(app.getHttpServer()).get(`/v1/modules/${dvtModule.id}/keys`);
 
         expect(resp.status).toEqual(200);
@@ -179,7 +178,7 @@ describe('SRModulesKeysController (e2e)', () => {
         });
       });
 
-      it('Should return unused keys and operator one', async () => {
+      it('Should return unused keys for operator one', async () => {
         const resp = await request(app.getHttpServer())
           .get(`/v1/modules/${dvtModule.id}/keys`)
           .query({ used: false, operatorIndex: 1 });
@@ -271,13 +270,13 @@ describe('SRModulesKeysController (e2e)', () => {
 
       it('Should return all keys that satisfy the request', async () => {
         const pubkeys = [dvtModuleKeys[0].key, dvtModuleKeys[1].key];
-        // Get all keys and operators without filters
+
         const resp = await request(app.getHttpServer())
           .post(`/v1/modules/${dvtModule.id}/keys/find`)
           .set('Content-Type', 'application/json')
           .send({ pubkeys });
 
-        expect(resp.status).toEqual(201);
+        expect(resp.status).toEqual(200);
         expect(resp.body.data.keys).toEqual(expect.arrayContaining(dvtModuleKeys));
         expect(resp.body.data.module).toEqual(dvtModuleResp);
         expect(resp.body.meta).toEqual({
@@ -298,7 +297,7 @@ describe('SRModulesKeysController (e2e)', () => {
           .set('Content-Type', 'application/json')
           .send({ pubkeys });
 
-        expect(resp.status).toEqual(201);
+        expect(resp.status).toEqual(200);
         expect(resp.body.data.keys).toEqual([]);
         expect(resp.body.data.module).toEqual(dvtModuleResp);
         expect(resp.body.meta).toEqual({
@@ -362,7 +361,6 @@ describe('SRModulesKeysController (e2e)', () => {
       });
 
       it('Should return all keys for request without filters', async () => {
-        // Get all keys and operators without filters
         const resp = await request(app.getHttpServer()).get(`/v1/modules/keys`);
 
         expect(resp.status).toEqual(200);
@@ -440,7 +438,7 @@ describe('SRModulesKeysController (e2e)', () => {
         });
       });
 
-      it('Should return empty keys and operators lists for non-existent operator', async () => {
+      it('Should return empty keys lists for non-existent operator', async () => {
         const resp = await request(app.getHttpServer()).get(`/v1/modules/keys`).query({ operatorIndex: 777 });
 
         expect(resp.status).toEqual(200);

diff --git a/src/http/sr-modules-operators-keys/sr-modules-operators-keys.e2e-spec.ts b/src/http/sr-modules-operators-keys/sr-modules-operators-keys.e2e-spec.ts
@@ -120,7 +120,6 @@ describe('SRModulesOperatorsKeysController (e2e)', () => {
       });
 
       it('should return all keys for request without filters', async () => {
-        // Get all keys and operators without filters
         const resp = await request(app.getHttpServer()).get(`/v1/modules/${dvtModule.id}/operators/keys`);
 
         expect(resp.status).toEqual(200);