Remove extra interfaces #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n' into feat/val-189-readme-fix
Co-authored-by: Raman Siamionau <[email protected]>
…at/val-189-readme-fix
Amuhar
commented
Sep 14, 2023
…' into feat/val-275-validators-endpoint-e2e
…oint-e2e E2E SRModulesValidatorsController
…stors-keys-e2e E2E SRModuleOperatorsKeys
…nterfaces' into feat/val-189-module-id-validation
…n' into feat/val-275-sr-modules-keys-e2e
avsetsin
approved these changes
Sep 19, 2023
| import { RegistryKey } from '../../../common/registry'; | ||
|
|
||
| // TODO: it enough use key from registry , lets remove | ||
| export class CuratedKey extends Key { |
There was a problem hiding this comment.
remains the mention of CuratedKey in the readme
There was a problem hiding this comment.
It fixed in readme pr
| import { RegistryOperator } from '../../../common/registry'; | ||
|
|
||
| // TODO: it enough use operator from registry , lets remove | ||
| export class CuratedOperator extends Operator { |
There was a problem hiding this comment.
remains the mention of CuratedOperator in the readme
There was a problem hiding this comment.
It fixed in readme pr
src/http/common/entities/operator.ts
Outdated
Comment on lines
34
to
35
| @ApiProperty({ description: 'The maximum number of validators to stake for this operator' }) | ||
| stakingLimit: number; |
There was a problem hiding this comment.
I would say that this is the number of keys vetted by the DAO and that can be used for the deposit. So that there is no confusion with the target limit
src/http/keys/entities/index.ts
Outdated
| @@ -1,2 +1,2 @@ | |||
| export * from './response'; | |||
| export * from './key-with-module-address'; | |||
| // export * from './key-with-module-address'; | |||
Improvements after review
…-e2e E2E SRModulesKeys controller
…ation Module id validation and operators e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.