VAL-369: Use postgres in e2e

[AlexandrMov]

No description provided.

[Amuhar]

why ?

[Amuhar]

maybe instead we should set VALIDATOR_REGISTRY_ENABLE=false

[AlexandrMov]

This code will fail due to spread operators for CL_API_URLS and PROVIDERS_URLS, if some of them are missing:

lido-keys-api/src/common/config/config.service.ts

Lines 9 to 13 in 9d800c9

	public get secrets(): string[] {
	return [this.get('SENTRY_DSN') ?? '', ...this.get('CL_API_URLS'), ...this.get('PROVIDERS_URLS')]
	.filter((v) => v)
	.map((v) => String(v));
	}

Perhaps, this PR is not a good place to change this. We can create a task for that.

[Amuhar]

it is strange, we have VALIDATOR_REGISTRY_ENABLE=false specially not to provide CL_API_URLS
i dont think it will fail

[Amuhar]

yes, i checked , it will not fail
you could add this code in config.service.ts get function to check

and add in .env

VALIDATOR_REGISTRY_ENABLE=false without providing CL_API_URLS

    if (key == 'CL_API_URLS') {
      console.log('CL_URL', value);
      console.log(
        'secrets',
        [super.get('SENTRY_DSN') ?? '', ...super.get('CL_API_URLS'), ...super.get('PROVIDERS_URLS')]
          .filter((v) => v)
          .map((v) => String(v)),
      );
    }

[Amuhar]

did you add VALIDATOR_REGISTRY_ENABLE=false ?

[Amuhar]

it is important to add VALIDATOR_REGISTRY_ENABLE=false for such setup

[Amuhar]

@ValidateIf((e) => e.VALIDATOR_REGISTRY_ENABLE === true)
  @IsArray()
  @ArrayMinSize(1)
  @Transform(({ value }) => value.split(',').map((url) => url.replace(/\/$/, '')))
  CL_API_URLS: string[] = [];

[Amuhar]

i see, for validators tests it is impossible to set VALIDATOR_REGISTRY_ENABLE = false

[Amuhar]

sorry, before i mocked config , so it worked, now you are right

[Amuhar]

why do we name it test:e2e:docker ?

[Amuhar]

"test:e2e:docker": "mikro-orm schema:drop -r && mikro-orm migration:up && jest -i --config jest-e2e.json && chronix test - is a test running command

docker-compose --env-file=./.env -f docker-compose.e2e.yml up --build --abort-on-container-exit - container running

[AlexandrMov]

we can name it test:e2e:ci, WDYT?

[Amuhar]

lgtm