Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MIN_ACTIVATION_BALANCE, new correlation penalty #572

Open
wants to merge 5 commits into
base: feat/oracle-v5
Choose a base branch
from

Conversation

vgorkavenko
Copy link
Contributor

No description provided.

@vgorkavenko vgorkavenko added the V5 label Dec 9, 2024
@vgorkavenko vgorkavenko changed the title feat: new correlation penalty feat: MIN_ACTIVATION_BALANCE, new correlation penalty Dec 12, 2024
@vgorkavenko vgorkavenko changed the base branch from develop to feat/oracle-v5 December 12, 2024 09:52
@hweawer hweawer self-requested a review December 17, 2024 14:53
src/constants.py Outdated Show resolved Hide resolved
@vgorkavenko vgorkavenko force-pushed the feat/new-correlation-penalty branch from f0669ad to 0ac1cd2 Compare December 20, 2024 12:16
slashings = Gwei(bound_slashed_validators_count * MAX_EFFECTIVE_BALANCE)
# We don't know validators effective balances on the moment of slashing,
# so we assume that it was at least `effective_balance`
slashings = Gwei(sum(int(v.validator.effective_balance) for v in bound_slashed_validators))
Copy link
Member

@F4ever F4ever Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks compatibility with current version.
Split old and new logic.
Smth like bound_slashed_validators_v0 and bound_slashed_validators_v1_electra and call them depending on network state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants