fix(completions): add quotes as triggerCharacter #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template completions for the "on" modifier event names were not being triggered
lifeart
approved these changes
Oct 1, 2023
lifeart
merged commit ece2345
into
lifeart:component-context-info-origin
6 checks passed
lifeart
pushed a commit
that referenced
this pull request
Oct 1, 2023
# [2.30.0](v2.29.0...v2.30.0) (2023-10-01) ### Features * add quotes as triggerCharacter ([#415](#415)) ([ece2345](ece2345))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #408
I noticed that template completions for the "on" modifier event names were not being triggered. This was due to quote characters not being listed as
triggerCharactersso theonCompletehook in the TemplateCompletionProvider was not being called.