Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in yield-context-extractor.ts #417

Conversation

camerondubas
Copy link

Follow up to #416 fixing some typos. I added a couple of extra tests that actually hit the ElementNode and BlockStatment code paths since there wasn't coverage before.

I'm not super familiar with this stuff, but I think we could simplify ElementNode a bit. Since an HTML element can't be yielded there isn't really a need to compute their modifiers and attributes. This info never gets used. Please correct me if I'm wrong! Happy to open a PR for that as well

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4635e71) 72.84% compared to head (c05e246) 72.84%.
Report is 1 commits behind head on component-context-info-origin.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           component-context-info-origin     #417   +/-   ##
==============================================================
  Coverage                          72.84%   72.84%           
==============================================================
  Files                                 57       57           
  Lines                               4967     4967           
  Branches                             979      979           
==============================================================
  Hits                                3618     3618           
  Misses                              1349     1349           
Files Coverage Δ
src/utils/yield-context-extractor.ts 56.80% <20.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lifeart
Copy link
Owner

lifeart commented Oct 2, 2023

Hi @camerondubas, thank you for contribution!
Technically, we could yield element, using https://github.com/tildeio/ember-element-helper

@lifeart lifeart merged commit 9d8019b into lifeart:component-context-info-origin Oct 2, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants