fix: remove multi-character triggerCharacters, yielded block completion #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSCode ignores these as they should be single characters only
Due to trigger characters being limited to a single character the completion request is triggered when `<` is typed. At that point both AngleBracketComponents and yielded blocks are relevant.
lifeart
approved these changes
Oct 4, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## component-context-info-origin #418 +/- ##
=================================================================
+ Coverage 72.84% 72.92% +0.08%
=================================================================
Files 57 57
Lines 4967 4968 +1
Branches 979 979
=================================================================
+ Hits 3618 3623 +5
+ Misses 1349 1345 -4
☔ View full report in Codecov by Sentry. |
lifeart
merged commit 467ab0d
into
lifeart:component-context-info-origin
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCode doesn't seem to support mutli-character triggerCharacters (relevant issue microsoft/language-server-protocol#138), so currently the
::,{{, andthis.characters don't do anything. Instead, it's preferable to use the last character in the sequence as the trigger. I also added#to support Handlebars blocks like#each.Fixes:
{{is typed, rather than after another character is pressed.#each) and block curly components ({{#foo}}) add closing tags automatically<:) work.<now include relevant yielded blocks in addition to components.I believe this closes #388
els-before-trigger-character-work.mp4
els-after-trigger-character-work.mp4