LPD-39505 Add playwright test to View Selected Web Content With Geolocation Field #6019

gergelyszalay · 2024-10-21T11:52:22Z

Cannot edit structure key when disabling configuration

What is this trying to solve?

https://liferay.atlassian.net/browse/LPD-39805,
https://liferay.atlassian.net/browse/LPD-39805

The geolocation field properly displayed in a web content display

How am I fixing it?

moved the test to the playwright, the 2 tests could be merged into one.

How can you verify that it works?
Run the tests locally

liferay-continuous-integration · 2024-10-21T11:52:26Z

CI is automatically triggering the following test suites:

ci:test:sf

gergelyszalay · 2024-10-21T11:53:31Z

ci:test:content-management-playwright

liferay-continuous-integration · 2024-10-21T11:57:20Z

❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b3033ae367d39f24e7266bcc4ce388726cab038e

Sender Branch:

Branch Name: LPD-39505-master
Branch GIT ID: 45e9d77c0886c7a089a228d435143c484e7277d1

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ⚙️ Running preflight checks...
     [exec] 
     [exec] ⚙️ Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ⚙️ Running TypeScript checks on modified files...
     [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
     [exec] 
     [exec] ⚙️ Running format checks on modified files...
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/journal-web/config.ts
     [exec]      11:3  error  Expected object keys to be in natural ascending order. 'permissions' should be before 'testIdAttribute'.  sort-keys
     [exec]      12:3  error  Expected object keys to be in natural ascending order. 'geolocation' should be before 'permissions'.  sort-keys
     [exec]    
     [exec]    ✖ 2 problems (2 errors, 0 warnings)
     [exec]    
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/journal-web/journalArticle.spec.ts
     [exec]      8:2  error  'chromium' is defined but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      29:8  error  'getContainerDefinition' is defined but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      30:8  error  'getPageDefinition' is defined but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      31:8  error  'getWidgetDefinition' is defined but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      145:3  error  'widgetPagePage' is defined but never used. Allowed unused args must match /^_|^this\$/u.  @typescript-eslint/no-unused-vars
     [exec]      159:6  error  Expected object keys to be in natural ascending order. 'dataType' should be before 'repeatable'.  sort-keys
     [exec]    
     [exec]    ✖ 6 problems (6 errors, 0 warnings)
     [exec]    
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/journal-web/pages/JournalEditTemplatePage.ts
     [exec]      8:9  error  'clickAndExpectToBeVisible' is defined but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      84:40  error  Expected object keys to be in natural ascending order. 'exact' should be before 'name'.  sort-keys
     [exec]

liferay-continuous-integration · 2024-10-21T11:59:27Z

Jenkins Build:test-portal-source-format#7374

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-content-management#6019

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - gergelyszalay > liferay-content-management - PR#6019 - 2024-10-21[04:52:35]

Testray Build ID:47710905

Testray Importer:publish-testray-report#28093

gergelyszalay · 2024-10-21T12:07:50Z

ci:test:sf

liferay-continuous-integration · 2024-10-21T12:12:40Z

❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b3033ae367d39f24e7266bcc4ce388726cab038e

Sender Branch:

Branch Name: LPD-39505-master
Branch GIT ID: 1d5b2cb537d1d0ac9202764f7a5b7fad8bae1da8

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ⚙️ Running preflight checks...
     [exec] 
     [exec] ⚙️ Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ⚙️ Running TypeScript checks on modified files...
     [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
     [exec] 
     [exec] ⚙️ Running format checks on modified files...
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/journal-web/config.ts
     [exec]      1:1  error  File has format errors.  (format check)
     [exec]    
     [exec]    ✖ 1 problem (1 error, 0 warnings)
     [exec]    
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/journal-web/journalArticle.spec.ts
     [exec]      8:2  error  'chromium' is defined but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      29:8  error  'getContainerDefinition' is defined but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      30:8  error  'getPageDefinition' is defined but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      31:8  error  'getWidgetDefinition' is defined but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      145:3  error  'widgetPagePage' is defined but never used. Allowed unused args must match /^_|^this\$/u.  @typescript-eslint/no-unused-vars
     [exec]      159:6  error  Expected object keys to be in natural ascending order. 'dataType' should be before 'repeatable'.  sort-keys
     [exec]    
     [exec]    ✖ 6 problems (6 errors, 0 warnings)
     [exec]    
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/journal-web/pages/JournalEditTemplatePage.ts
     [exec]      8:9  error  'clickAndExpectToBeVisible' is defined but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      84:40  error  Expected object keys to be in natural ascending order. 'exact' should be before 'name'.  sort-keys
     [exec]    
     [exec]    ✖ 2 problems (2 errors, 0 warnings)
     [exec]    
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/journal-web/utils/getDataStructureDefinition.ts

liferay-continuous-integration · 2024-10-21T12:14:48Z

Jenkins Build:test-portal-source-format#10397

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-content-management#6019

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - gergelyszalay > liferay-content-management - PR#6019 - 2024-10-21[05:08:02]

Testray Build ID:47718566

Testray Importer:publish-testray-report#39690

liferay-continuous-integration · 2024-10-21T13:45:15Z

❌ ci:test:content-management-playwright - 10 out of 13 jobs passed in 1 hour 51 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b3033ae367d39f24e7266bcc4ce388726cab038e

Upstream Comparison:

Branch GIT ID: b3033ae367d39f24e7266bcc4ce388726cab038e
Jenkins Build URL: EE Development Acceptance (master) - 934 - 2024-10-21[00:02:58]

ci:test:content-management-playwright - 10 out of 13 jobs PASSED

3 Failed Jobs:

10 Successful Jobs:

For more details click here.

Failures unique to this pull:

playwright-js-tomcat90-mysql57/9/0 - Playwright Report
1. journal-web/journalArticle.spec.ts
  It ensures that translate side by side shows the duplicate fields
  LPD-28728: the default value of a structure is not deleted after the structure update
  LPD-28728: the value of a repeated field of an article is the same as the structure default value
  LPD-29527 - Can delete translation of a web content created from a structure with at least one required and non-localizable field
  View Selected Web Content With Geolocation Field
2. journal-web/journalArticleAutosave.spec.ts
  History button test
  Undo/Redo buttons work with content field
  Web content should be saved as draft after changing the title and the content

Failures in common with acceptance upstream results at b3033ae:

liferay-continuous-integration · 2024-10-21T13:47:28Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6854

Jenkins Report:jenkins-report.html

Jenkins Suite:content-management-playwright

Pull Request:liferay-content-management#6019

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:content-management-playwright - gergelyszalay > liferay-content-management - PR#6019 - 2024-10-21[04:53:44]

Testray Build ID:47903025

Testray Importer:publish-testray-report#25409

gergelyszalay · 2024-10-21T15:08:00Z

ci:test:sf

liferay-continuous-integration · 2024-10-25T09:40:49Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1dbaed3be11b249c7cfd3dc514db825793b235ee

Sender Branch:

Branch Name: LPD-39505-master
Branch GIT ID: 0209a4a654e7768c9ba837ae16df03b048dacd11

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2024-10-25T09:42:33Z

Jenkins Build:test-portal-source-format#9246

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-content-management#6019

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - gergelyszalay > liferay-content-management - PR#6019 - 2024-10-25[02:35:25]

Testray Build ID:52029682

Testray Importer:publish-testray-report#34790

liferay-continuous-integration · 2024-10-25T11:06:42Z

❌ ci:test:content-management-playwright - 11 out of 13 jobs passed in 1 hour 30 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1dbaed3be11b249c7cfd3dc514db825793b235ee

Upstream Comparison:

Branch GIT ID: 1dbaed3be11b249c7cfd3dc514db825793b235ee
Jenkins Build URL: EE Development Acceptance (master) - 950 - 2024-10-24[20:45:23]

ci:test:content-management-playwright - 11 out of 13 jobs PASSED

2 Failed Jobs:

11 Successful Jobs:

For more details click here.

Failures unique to this pull:

playwright-js-tomcat90-mysql57/9/0 - Playwright Report
1. journal-web/journalArticle.spec.ts
  It ensures that translate side by side shows the duplicate fields
  LPD-28728: the default value of a structure is not deleted after the structure update
  LPD-28728: the value of a repeated field of an article is the same as the structure default value
  LPD-29527 - Can delete translation of a web content created from a structure with at least one required and non-localizable field
  View Selected Web Content With Geolocation Field
2. journal-web/journalArticleAutosave.spec.ts
  History button test
  Undo/Redo buttons work with content field
  Web content should be saved as draft after changing the title and the content

Failures in common with acceptance upstream results at 1dbaed3:

playwright-js-tomcat90-mysql57/9/0 - Playwright Report
1. journal-web/journalArticleAutosave.spec.ts
  Info message appears when autosave is failed due to missing required fields
  Translation is removed when using Undo and restored when using Redo
  Undo/Redo buttons work with metadata fields

liferay-continuous-integration · 2024-10-25T11:08:54Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#14100

Jenkins Report:jenkins-report.html

Jenkins Suite:content-management-playwright

Pull Request:liferay-content-management#6019

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:content-management-playwright - gergelyszalay > liferay-content-management - PR#6019 - 2024-10-25[02:36:12]

Testray Build ID:52130338

Testray Importer:publish-testray-report#32822

gergelyszalay · 2024-11-05T15:23:20Z

ci:test:content-management-playwright

liferay-continuous-integration · 2024-11-05T16:50:44Z

❌ ci:test:content-management-playwright - 11 out of 14 jobs passed in 1 hour 19 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1257401_6216

Base Branch:

Branch Name: master
Branch GIT ID: 018c46ee4f7af1eb39b9cf0ec93f43f92aabdb3a

Upstream Comparison:

Branch GIT ID: a5e032e394aa5a9423586cecf372df569abc654e
Jenkins Build URL: EE Development Acceptance (master) - 983 - 2024-11-05[04:42:43]

ci:test:content-management-playwright - 11 out of 14 jobs PASSED

3 Failed Jobs:

11 Successful Jobs:

For more details click here.

Failures unique to this pull:

playwright-js-tomcat90-mysql57/4/0 - Playwright Report
1. journal-web/journalArticle.spec.ts
  It ensures that translate side by side shows the duplicate fields
  LPD-28728: the default value of a structure is not deleted after the structure update
  LPD-28728: the value of a repeated field of an article is the same as the structure default value
  LPD-29527 - Can delete translation of a web content created from a structure with at least one required and non-localizable field
  View Selected Web Content With Geolocation Field
2. journal-web/journalArticleAutosave.spec.ts
  History button test
  Undo/Redo buttons work with content field
  Web content should be saved as draft after changing the title and the content

Failures in common with acceptance upstream results at a5e032e:

liferay-continuous-integration · 2024-11-05T16:53:11Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6216

Jenkins Report:jenkins-report.html

Jenkins Suite:content-management-playwright

Pull Request:liferay-content-management#6019

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:content-management-playwright - gergelyszalay > liferay-content-management - PR#6019 - 2024-11-05[07:31:59]

Testray Build ID:60252467

Testray Importer:publish-testray-report#12830

…cation Field

…ebContentWithGeolocationField

…Field Poshi test

gergelyszalay · 2024-11-15T15:42:57Z

ci:test:content-management-playwright

liferay-continuous-integration · 2024-11-15T16:52:07Z

❌ ci:test:content-management-playwright - 12 out of 14 jobs passed in 1 hour 9 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 31cad2ae57a0a7537cf2c8e86875c372d36d8ab3

Upstream Comparison:

Branch GIT ID: 31cad2ae57a0a7537cf2c8e86875c372d36d8ab3
Jenkins Build URL: EE Development Acceptance (master) - 1020 - 2024-11-15[04:40:19]

ci:test:content-management-playwright - 12 out of 14 jobs PASSED

2 Failed Jobs:

12 Successful Jobs:

For more details click here.

Failures unique to this pull:

playwright-js-tomcat90-mysql57/4/0 - Playwright Report
1. journal-web/journalArticle.spec.ts
  It ensures that translate side by side shows the duplicate fields
  LPD-28728: the default value of a structure is not deleted after the structure update
  LPD-28728: the value of a repeated field of an article is the same as the structure default value
  LPD-29527 - Can delete translation of a web content created from a structure with at least one required and non-localizable field
  View Selected Web Content With Geolocation Field
2. journal-web/journalArticleAutosave.spec.ts
  History button test
  Undo/Redo buttons work with content field
  Undo/Redo buttons work with metadata fields
  Web content should be saved as draft after changing the title and the content

For upstream results, click here.

liferay-continuous-integration · 2024-11-15T16:56:50Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#10454

Jenkins Report:jenkins-report.html

Jenkins Suite:content-management-playwright

Pull Request:liferay-content-management#6019

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:content-management-playwright - gergelyszalay > liferay-content-management - PR#6019 - 2024-11-15[07:43:09]

Testray Build ID:69892366

Testray Importer:publish-testray-report#24869

liferay-content-management added the 🔍 qa review needed label Oct 21, 2024

liferay-continuous-integration added ci:test:sf - pending ci:test:content-management-playwright - pending ci:test:sf - failure ci:test:relevant - failure ci:test:stable - failure and removed ci:test:sf - pending labels Oct 21, 2024

gergelyszalay force-pushed the LPD-39505-master branch from 45e9d77 to 1d5b2cb Compare October 21, 2024 12:07

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure ci:test:relevant - failure ci:test:stable - failure and removed ci:test:sf - failure ci:test:sf - pending ci:test:relevant - failure ci:test:stable - failure labels Oct 21, 2024

liferay-continuous-integration added ci:test:content-management-playwright - failure and removed ci:test:content-management-playwright - pending labels Oct 21, 2024

gergelyszalay force-pushed the LPD-39505-master branch from 1d5b2cb to 02cc3d7 Compare October 21, 2024 15:07

liferay-continuous-integration removed the ci:test:sf - failure label Oct 21, 2024

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:stable - success labels Oct 25, 2024

liferay-continuous-integration added ci:test:content-management-playwright - failure and removed ci:test:content-management-playwright - pending labels Oct 25, 2024

gergelyszalay added the ⛔️ on hold label Oct 28, 2024

gergelyszalay force-pushed the LPD-39505-master branch from 0209a4a to afc1a23 Compare November 5, 2024 15:23

liferay-continuous-integration added ci:test:content-management-playwright - pending ci:test:content-management-playwright - failure and removed ci:test:content-management-playwright - failure ci:test:content-management-playwright - pending labels Nov 5, 2024

gergelyszalay added 4 commits November 15, 2024 16:42

LPD-39505 Add create Template to JournalEditTemplatePage

37a11b8

LPD-39505 Add playwright test to View Selected Web Content With Geolo…

5486110

…cation Field

LPD-39505 Removing ContentDisplayWithWebContentTemplate#ViewSelectedW…

d481b1b

…ebContentWithGeolocationField

LPD-39505 Removing WebContentDisplay#DisplayWebContentWithGeolocation…

d63e98d

…Field Poshi test

gergelyszalay force-pushed the LPD-39505-master branch from afc1a23 to d63e98d Compare November 15, 2024 15:42

liferay-continuous-integration added ci:test:content-management-playwright - pending ci:test:content-management-playwright - failure and removed ci:test:content-management-playwright - failure ci:test:content-management-playwright - pending labels Nov 15, 2024

LPD-39505 Add playwright test to View Selected Web Content With Geolocation Field #6019

Are you sure you want to change the base?

LPD-39505 Add playwright test to View Selected Web Content With Geolocation Field #6019

Conversation

gergelyszalay commented Oct 21, 2024

liferay-continuous-integration commented Oct 21, 2024

gergelyszalay commented Oct 21, 2024

liferay-continuous-integration commented Oct 21, 2024

❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Oct 21, 2024

gergelyszalay commented Oct 21, 2024

liferay-continuous-integration commented Oct 21, 2024

❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Oct 21, 2024

liferay-continuous-integration commented Oct 21, 2024

❌ ci:test:content-management-playwright - 10 out of 13 jobs passed in 1 hour 51 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Oct 21, 2024

gergelyszalay commented Oct 21, 2024

liferay-continuous-integration commented Oct 25, 2024

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 25, 2024

liferay-continuous-integration commented Oct 25, 2024

❌ ci:test:content-management-playwright - 11 out of 13 jobs passed in 1 hour 30 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Oct 25, 2024

gergelyszalay commented Nov 5, 2024

liferay-continuous-integration commented Nov 5, 2024

❌ ci:test:content-management-playwright - 11 out of 14 jobs passed in 1 hour 19 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Nov 5, 2024

gergelyszalay commented Nov 15, 2024

liferay-continuous-integration commented Nov 15, 2024

❌ ci:test:content-management-playwright - 12 out of 14 jobs passed in 1 hour 9 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

liferay-continuous-integration commented Nov 15, 2024