fix: Two functions have the same icon in the same toolbar (#1495) #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @markocikos, Would you like to leave a comment? |
|
Hi @diegonvs , since the PR has passed your review, can you please move this PR forward? Thanks! |
|
LGTM too :) Merging :D |
javiergamarra
added a commit
to javiergamarra/liferay-portal
that referenced
this pull request
Aug 5, 2021
Motivation - get fix from this PR:
liferay/alloy-editor#1496
Full release notes:
https://github.com/liferay/alloy-editor/releases/tag/v2.14.3
brianchandotcom
pushed a commit
to brianchandotcom/liferay-portal
that referenced
this pull request
Aug 6, 2021
Motivation - get fix from this PR:
liferay/alloy-editor#1496
Full release notes:
https://github.com/liferay/alloy-editor/releases/tag/v2.14.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is fixing #1495 , two functions have the same icon on the same toolbar, which is confusing.
Please review!
Thanks!
(Additional info can be found in the comment section of https://issues.liferay.com/browse/PTR-2571 )