Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Button): LPD-17350 - Buttons - Simplify Clay page and align to Lexicon #5784

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

ilzamcmed
Copy link
Member

@ilzamcmed ilzamcmed commented Mar 15, 2024

Jira issue: https://liferay.atlassian.net/browse/LPD-17350

  • Adding borderless example
  • Removing unstyled, null, translucent, and beta examples.
  • The translucent example can be found in the storybook already, among with the types.

Documentation preview

@ilzamcmed
Copy link
Member Author

Hey @matuzalemsteles @pat270
This PR is ready for review!
Thanks!

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilzamcmed I think we can remove part of this text too since we don't want unstyled documenting.

Set `displayType` to `unstyled` to reset all the stylings from Bootstrap 4.

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hey @drakonux or @emiliano-cicero can you validate this here before merging?

…null, unstyled, translucent and beta buttons example
@ilzamcmed
Copy link
Member Author

Hey @matuzalemsteles, I updated the docs by adding a space between the buttons, as requested on this Slack discussion.
Thanks!

@matuzalemsteles matuzalemsteles merged commit 85ce1a2 into liferay:master Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants