scrubbed through app widgets and added localization text #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykdavies
reviewed
Aug 24, 2023
lib/pages/communities_tab.dart
Outdated
| child: Text('You are not logged in to any instances'), | ||
| ? Center( | ||
| child: Text(L10n.of(context).not_logged_in), | ||
| //child: Text('You are not logged in to any instances'), // TODO localize this string |
There was a problem hiding this comment.
Safe to remove the TODO now 😄
There was a problem hiding this comment.
updated with latest commit good catch haha
mykdavies
reviewed
Aug 25, 2023
|
@mykdavies I have cleaned up the TODOs and added a few more localized strings. Should be good now. Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few new English strings and descriptors to the en.arb file. Replaced some existing static strings in several of the widgets to utilize the L10n localization instead of static English strings.