-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LNURL-withdrawPOS flow #16
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @theDavidCoen, documenting this protocol is definitely overdue, so thanks for picking up the slack.
I went through and commented whenever something jumped at me, some of the comments are more pedantic than necesary so feel free to ignore, but I wanted to give concrete examples of how I'd written it (doesn't mean that mine would have been any more correct) :-)
3. Confirm | ||
|
||
In this repo I schematize a LNURL-withdraw flow for POS, | ||
which sees the interaction between the user and a POS equipped with a NFC sensor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NFC in this case seems more like an example transport rather than an explicit limitation.
blip-0015.md
Outdated
In this repo I schematize a LNURL-withdraw flow for POS, | ||
which sees the interaction between the user and a POS equipped with a NFC sensor. | ||
|
||
This bLIP serves to document what could be a reference flow for open source implementations of POS devices able to read LNURL-withdraw links via NFC, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bLIP serves to document what could be a reference flow for open source implementations of POS devices able to read LNURL-withdraw links via NFC, | |
This bLIP serves to documents the flow for open source implementations of POS devices able to read LNURL-withdraw links via NFC, |
Again, NFC seems more like a detail here, artificially limiting the applicability (links, QR codes, etc are just as valid as transports).
blip-0015.md
Outdated
which sees the interaction between the user and a POS equipped with a NFC sensor. | ||
|
||
This bLIP serves to document what could be a reference flow for open source implementations of POS devices able to read LNURL-withdraw links via NFC, | ||
for a better UX in Lightning payments powered by LNURL protocol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better
as compared to what?
Co-authored-by: Christian Decker <[email protected]>
Co-authored-by: Christian Decker <[email protected]>
Ehy @cdecker thanks a lot for your comments and suggestions!
|
Ciao @theDavidCoen.
|
@cdecker sorry for the late reply. |
Isn't this spec heavily dependent on the LNURL specifications?
|
@GeorgeTsagk thanks for your comment.
|
Chiming in to agree with David that the LNURL specs could totally be a set of blips (one for each LUD) |
I'd like this, and the other LNURL specs, to be mirrored here, since they are being adopted by a large number of implementations, wallets and services, and are clearly part of the LN ecosystem. It'd serve as an acknowledgement and would facilitate finding them by developers looking for solutions to their problems. Notice that in this repository we only perform stylistic and understandability checks, not discussions on the merits or design choices in order not to dissuade users from pursuing various solutions, as such there would be no barrier to mirroring LNURL, and you might get some feedback on whether the documentation is complete and understandable (I too sometimes take things as given, but they are only because I was present while they were discussed, and someone joining later might not have that context). This is however completely up to the LNURL team to decide. |
Pull request for blip regarding LNURL-withdrawPOS flow standard.