-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routing+htlcswitch: fix stuck inflight payments #9150
Open
yyforyongyu
wants to merge
8
commits into
lightningnetwork:master
Choose a base branch
from
yyforyongyu:fix-stuck-payment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
routing+htlcswitch: fix stuck inflight payments #9150
yyforyongyu
wants to merge
8
commits into
lightningnetwork:master
from
yyforyongyu:fix-stuck-payment
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cd6bf9f - Browse repository at this point
Copy the full SHA cd6bf9fView commit details -
channeldb+routing: cache circuit and onion blob for htlc attempt
This commit caches the creation of sphinx circuit and onion blob to avoid re-creating them again.
Configuration menu - View commit details
-
Copy full SHA for 2727c2a - Browse repository at this point
Copy the full SHA 2727c2aView commit details -
routing: add new method
reloadInflightAttempts
To shorten the method `resumePayment` and make each step more clear.
Configuration menu - View commit details
-
Copy full SHA for ced1f7c - Browse repository at this point
Copy the full SHA ced1f7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4a04f5 - Browse repository at this point
Copy the full SHA d4a04f5View commit details -
routing: add new method
refreshPayment
To further shorten the lifecycle loop.
Configuration menu - View commit details
-
Copy full SHA for 689c215 - Browse repository at this point
Copy the full SHA 689c215View commit details -
routing: always update payment in the same goroutine
This commit refactors `collectResultAsync` such that this method is now only responsible for collecting results from the switch. A new method `processSwitchResults` is added to process these results in the same goroutine where we fetch the payment from db, to make sure the lifecycle loop always have a consistent view of a given payment.
Configuration menu - View commit details
-
Copy full SHA for 95e57b1 - Browse repository at this point
Copy the full SHA 95e57b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f846fb8 - Browse repository at this point
Copy the full SHA f846fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b631432 - Browse repository at this point
Copy the full SHA b631432View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.