feat: add netrc support #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it's necessary to do a breaking change. You can strip the prefix until Also, can you put custom github instance support in a separate commit? |
backwards compatible
blaggacao
force-pushed
the
feat/support-netrcs
branch
from
8cc31ae
to
fbd43fd
Compare
|
@lilydjwg done so far, please feel free to review again and thanks for accepting this feature. |
lilydjwg
requested changes
Mar 4, 2024
while the old way of declaring the keys is still available it is no longer documented this should encourage new users to use the new, netrc-compatible way
blaggacao
force-pushed
the
feat/support-netrcs
branch
from
fbd43fd
to
f8a73a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to the removal of the prefix key in the token configuration, this is a breaking change.closes #251
I tested and confirmed that I could use my netrc file (withou using the keyfile) to access the relevant gitlab token and it detected correctly the version update.