Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Make sure eegeyenet_urls.csv gets included in package data durin… #14

Merged
merged 6 commits into from
May 13, 2024
Merged

FIX: Make sure eegeyenet_urls.csv gets included in package data durin… #14

merged 6 commits into from
May 13, 2024

Commits on May 13, 2024

  1. FIX: Make sure eegeyenet_urls.csv gets included in package data durin… 

    …g static install

The CSV file added in 957f98d isn't getting downloaded during static install.

Might be because of the include_package_data flag, see

https://stackoverflow.com/questions/7522250/how-to-include-package-data-with-setuptools-distutils
    @scott-huberty
    scott-huberty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4f67e0f View commit details
    Browse the repository at this point in the history

  2. Revert "FIX: Make sure eegeyenet_urls.csv gets included in package da… 

    …ta during static install"

This reverts commit 4f67e0f.
    @scott-huberty
    scott-huberty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    72e910d View commit details
    Browse the repository at this point in the history

  3. FIX: add CSV file to setuptools.package-data 

    Also see https://stackoverflow.com/questions/69647590/specifying-package-data-in-pyproject-toml
    @scott-huberty
    scott-huberty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e52a822 View commit details
    Browse the repository at this point in the history

  4. Set include-package-data to True

    @scott-huberty
    scott-huberty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7534119 View commit details
    Browse the repository at this point in the history

  5. FIX: dont capitalize booleans?

    @scott-huberty
    scott-huberty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d5368ab View commit details
    Browse the repository at this point in the history

  6. Delete Commented lines

    @scott-huberty
    scott-huberty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e69d50a View commit details
    Browse the repository at this point in the history