Incorporate Christian revisions & fix a bug with creating events from annotations #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the source of the bug where we were epoching to data that werent synced to the flash times. While both of the EEG and ET raws are the same length after mne realign_raw and thus you should be able to epoch the ET objet to the EEG events, the original EEG raw and ET raw had different orig_times and so setting EEG annots to ET raw will put them in the wrong place. This is a documented limiation of annotations. if t0 is not 0, annotations can behave weird.
Mostly just black formatting, adding docstring, and sorting imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch was pulled from Christian's forks, and added a couple fixes on top.
Regarding the issue where the Evoked responses appeared to not be time-locked to the flash stimulus, Our initial suspect of annotations was true. In the initial commit of this PR, in
eoglearn/datasets/mne.py, we set the EEG annotations to the ET raw object. The fix is to set the ET annotations to the ET object (which also contains EEG channels, bc we didraw_et.add_channels([raw_eeg]).