Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing topomaps. #130

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Fixing topomaps. #130

merged 10 commits into from
Oct 26, 2023

Commits on Jun 2, 2023

  1. Fixing topomaps.

    @christian-oreilly
    christian-oreilly committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    7ab4c59 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Merge remote-tracking branch 'upstream/main' into 129-bug-in-topomaps 

    Rebased with main, fixed conflicts from changes in this PR. I always accepted the changes in THIS PR, and formated with black after accepting the change.
    @scott-huberty
    scott-huberty committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    77865f9 View commit details
    Browse the repository at this point in the history

  2. FIX: Make topomap cmaps look like MNE 

    These last couple fixes will make our topomaps look like MNEs. It mainly had to
do with some logic to handle the cmap and vmin/vmax
    @scott-huberty
    scott-huberty committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    3dd5988 View commit details
    Browse the repository at this point in the history

  3. FIX: unused variable in my new code

    @scott-huberty
    scott-huberty committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    e41d9a3 View commit details
    Browse the repository at this point in the history

  4. DOC: add docstring to a function added in this PR

    @scott-huberty
    scott-huberty committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    c9499d4 View commit details
    Browse the repository at this point in the history

  5. FIX: FORGOT to initiate cmap as None 

    We should initiate the cmap as None instead of "Red_bl" (sic), so that
our code logic can handle the color scheme based on the IC values just like
MNE does
    @scott-huberty
    scott-huberty committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    44a3407 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. FIX, TST: revert change in test_GridTopoPlot

    @scott-huberty
    scott-huberty committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    266caf2 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Update pylossless/dash/topo_viz.py 

    Co-authored-by: Scott Huberty <[email protected]>
    @christian-oreilly @scott-huberty
    christian-oreilly and scott-huberty authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    1013ef0 View commit details
    Browse the repository at this point in the history

  2. Update pylossless/dash/topo_viz.py 

    Co-authored-by: Scott Huberty <[email protected]>
    @christian-oreilly @scott-huberty
    christian-oreilly and scott-huberty authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6896d73 View commit details
    Browse the repository at this point in the history

  3. Update pylossless/dash/topo_viz.py 

    Co-authored-by: Scott Huberty <[email protected]>
    @christian-oreilly @scott-huberty
    christian-oreilly and scott-huberty authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f264469 View commit details
    Browse the repository at this point in the history