Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Setup a pytest fixture for reuse across tests #144

Merged
merged 7 commits into from
Oct 26, 2023
Merged

MAINT: Setup a pytest fixture for reuse across tests #144

merged 7 commits into from
Oct 26, 2023

Conversation

scott-huberty
Copy link
Member

@scott-huberty scott-huberty commented Oct 26, 2023

It's taking a long time to run our test suite, and the reason is that in test_pipeline, multiple tests are literally re running the entire pipeline (including two ICA's!) on a file that isn't really a test file to begin with (it's more than a minute long).

This sets up a pytest fixture so that we can just run this file through the pipeline once, and reuse it across all of our tests. This will be especially handy for #138 , because that PR is currently running the pipeline on a file yet another time for the rejection tests.

On my local, the entire test suite is running less than 30 seconds. let's see this improves the testing time on the VM's.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #144 (4a4d0d9) into main (510b992) will decrease coverage by 9.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   77.63%   68.15%   -9.49%     
==========================================
  Files          12       13       +1     
  Lines         921      942      +21     
==========================================
- Hits          715      642      -73     
- Misses        206      300      +94     
Files Coverage Δ
pylossless/conftest.py 100.00% <100.00%> (ø)
pylossless/dash/tests/test_topo_viz.py 80.00% <100.00%> (-20.00%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scott-huberty
Copy link
Member Author

So actually the dash tests are the real culprit for our test suite taking so long now. test_topoviz alone is taking ~10 minutes. It is failing and there is something that needs to be debugged. Marking with pytest.mark.skip for now.

@scott-huberty scott-huberty merged commit c322d35 into lina-usc:main Oct 26, 2023
4 of 5 checks passed
@scott-huberty scott-huberty mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant