Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Take photos and videos and record voice memos #961

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Feature: Take photos and videos and record voice memos #961

wants to merge 14 commits into from

Conversation

KhaledNjim
Copy link
Collaborator

@KhaledNjim KhaledNjim commented Jun 10, 2024 •
edited
Loading

User story

Demo (android 34)

34.webm

Demo (android 33)

Screen_recording_20240603_211703.webm

Demo (android 28)

28.webm

Demo (android 27)

27.webm

Camera permission demo

permission_cam.webm

Audio recording permission demo

recper.webm

Open settings when permission is permantly denied

openSettings.webm

@KhaledNjim KhaledNjim requested a review from hoangdat June 10, 2024 04:49
@hoangdat
Copy link
Member

What is 1267? Can you describe about this issue in ADR or in github ticket, and reference commits to it?

@hoangdat
Copy link
Member

hoangdat commented Jun 10, 2024 •
edited by KhaledNjim
Loading

  • demo for handling permission case also
  • demo for iOS too

hoangdat
hoangdat reviewed Jun 10, 2024
View reviewed changes
ios/Runner/Info.plist Outdated Show resolved Hide resolved
hoangdat
hoangdat reviewed Jun 10, 2024
View reviewed changes
ios/Runner/Info.plist Outdated Show resolved Hide resolved
@KhaledNjim
Copy link
Collaborator Author

  • demo for handling permission case also
  • demo for iOS too

idont have mac for ios demo

@KhaledNjim
Copy link
Collaborator Author

What is 1267? Can you describe about this issue in ADR or in github ticket, and reference commits to it?

added adr

@hoangdat
Copy link
Member

what happen if you reject permission?

hoangdat
hoangdat reviewed Jun 12, 2024
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
@hoangdat
Copy link
Member

hoangdat commented Jun 12, 2024 •
edited
Loading

please use git fixup, dont use force push. It takes a lot of time to review the old one.
I will refuse to continue if you force push on this big changes.

@KhaledNjim
Copy link
Collaborator Author

what happen if you reject permission?

display a toast and return to the previous screen

@KhaledNjim KhaledNjim requested a review from hoangdat June 26, 2024 10:15
dab246
dab246 reviewed Nov 8, 2024
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
hoangdat
hoangdat reviewed Nov 11, 2024
View reviewed changes
lib/l10n/intl_messages.arb Outdated
"placeholders_order": [],
"placeholders": {}
},
"give_access_in_settings": "Please give linshare access in the settings to continue",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LinShare, Settings

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we should more detail on what permission and why we need it? This is a chance for clearer information to user.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

image

hoangdat
hoangdat reviewed Nov 11, 2024
View reviewed changes
lib/presentation/view/dialog/discard_confirmation_dialog.dart
child: Text(AppLocalizations.of(context).cancel),
),
TextButton(
onPressed: () => Navigator.of(context).pop(true),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to handle the case: user cancel here, and somewhere after capturing video/audio call, we should clear the temporary file too. Please demo this case also

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled

cache_cleanup.mp4

@hoangdat
Copy link
Member

The storage is not taken care well. When user refuse to upload it, storage still be increase

Screen_Recording_20241115_123258_LinShare.mp4

hoangdat
hoangdat approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@hoangdat hoangdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@hoangdat
Copy link
Member

hoangdat commented Nov 18, 2024 •
edited
Loading

Hi @wboudiche , @KhaledNjim
this PR was almost done, but still have some limitation:

  • capture video but can not too long (around 20s only)
  • please arrange the team to test that carefully.

Thanks.

@KhaledNjim
LA-1267 added weChatCameraPicker dependencie
43f3d8a
@KhaledNjim
Added ui elements for taking photos
ccf540d
@KhaledNjim
Added presentation layer for taking a photo or video
fb4a8f1
@KhaledNjim
Added redux/domain and presentation layer for audio recording
f05d1d2
@KhaledNjim
Updated ui for context menu in sharedSpace and mySpace
748e596
@KhaledNjim
Updated camera and microphone permission for ios
9675ccf
@KhaledNjim
Updated icons for file upload context menu in shared_space and my_space
c1f4605
@KhaledNjim
Changed redux action for camera picker
5a9d017
@KhaledNjim
added adr for audio recording and camera usage
57c24ca
@KhaledNjim
LA-1267 added confirmation before discarding recording
ac2296c
@KhaledNjim
LA-1267 Added handling for incoming phone calls while recording
58a9793
@KhaledNjim
LA-1267 Clean cache after canceling media capture
64841fb
@KhaledNjim
LA-1267 Update permission required dialog string
8ef2d4e
@KhaledNjim
LA-1267 Remove time limit for video recording
6fc0de4
@KhaledNjim
Copy link
Collaborator Author

Please rebase

@hoangdat done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dab246 dab246 dab246 left review comments

@hoangdat hoangdat hoangdat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhaledNjim @hoangdat @dab246