-
Notifications
You must be signed in to change notification settings - Fork 148
Definition Of Done
MichaelBailly edited this page Jun 27, 2019
·
15 revisions
The team agrees on these Definition Of Done (also named DoD). There can be several level and area for Definition Of Done
## DoD ready for dev Developer must have all information to work on the task without ambiguity. If dev have any doubt about what is asked, don't shut up and ask to be sure of what you have to do !
Testing team have all information to work on the task, meaning only test what is relevant for this task. A developer must ask himself if the following points are clear and defined in the ticket and not subject to interpreting; If they aren't, this must be clarified
- Dev done I have done what the Description/Acceptance Criteria asks for. If not, explain what.
- Comment All comments answered
- CI All PR merged & all Jenkins builds are success. If the build is not installed on regular oncommit platforms, then please explain why. The reference oncommit platform is https://openpaas.latest.integration-open-paas.org, updated nightly.
- Feature flipped If that's a feature not activated by default, please specify it.
- Feature availability If that's a feature not available by default (for example James part not implemented and Unified Inbox feature cannot be tested without a workaround), please write it.
- Impact Explain what features my change(s) may impact in the all product. According to your knowledge of the software/architecture, what are the possible side effects of your code change ?
- Tests done What tests did I executed to validate the fix?
- Environment tested: Browser? Smartphone? Desktop? If it impacts smartphone (or tablet) view, then a real smartphone (or a real tablet) must have been used to validate the fix. If not write it
- New bugs If new bugs have been encountered, gitlab(s) opened for them
- Documentation upgraded or added if non-existent
- If this issue will be fixed when another issue will be done, then don't mark this one "Closed" but add a comment and a link "Blocked by" to the ticket in the issue description.
- If this is a reopen, don't edit previous DoD comment but add a new one explaining what you've done
- Add the "QA:Testing" with your comment only if everything is OK and can be tested
There is no need to use a template and answer all these questions. Please just add in a comment what will be useful.