Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-1272 Team mailboxes over IMAP #1311

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ISSUE-1272 Team mailboxes over IMAP #1311

wants to merge 3 commits into from
+1,254 −9

Conversation

vttranlina
Copy link
Member

resolve #1272

@vttranlina vttranlina mentioned this pull request Nov 15, 2024
Open
2 tasks
@chibenwa
Copy link
Member

And screenshots in thunderbird please ;-)

@vttranlina
Copy link
Member Author

And screenshots in thunderbird please ;-)

image

@vttranlina vttranlina marked this pull request as ready for review November 18, 2024 07:58
quantranhong1999
quantranhong1999 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@quantranhong1999 quantranhong1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@vttranlina
Copy link
Member Author

Requirement:
james-code

chibenwa
chibenwa reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like good quality work.

In the end @vttranlina did using composition, rather than inheritance, lead to more boiler plate code being written?

@vttranlina
Copy link
Member Author

Not as much boilerplate code as I initially assumed.

@quantranhong1999
Copy link
Member

[ERROR] /home/jenkins/build/workspace/Tmail_build_PR-1311/tmail-backend/imap-extensions/src/main/java/com/linagora/tmail/imap/TMailPathConverter.java:[56,52] incompatible types: java.lang.String cannot be converted to java.util.Optional<java.lang.String>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantranhong1999 quantranhong1999 quantranhong1999 approved these changes

@chibenwa chibenwa chibenwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Team mailboxes over IMAP
3 participants
@vttranlina @chibenwa @quantranhong1999