Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3157 Implement web socket push #3168

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Sep 23, 2024

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3168.

@dab246
Copy link
Member

dab246 commented Sep 24, 2024

  • Verify web socket when token expired
  • Verify web socket on background mode

@tddang-linagora tddang-linagora changed the title [WIP] TF-3157 Implement web socket push TF-3157 Implement web socket push Sep 25, 2024
@hoangdat hoangdat changed the title TF-3157 Implement web socket push [WIP] TF-3157 Implement web socket push Sep 26, 2024
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please remove firebase-messaging-sw.js file in web folder when we already used weg socket

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove code fcm on web

@dab246
Copy link
Member

dab246 commented Nov 5, 2024

  • Sometime not work on chrome: Go to setting -> send email -> back to dashboard screen -> not update
Screen.Recording.2024-11-05.at.10.36.31.mov

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please rebase it

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hoangdat hoangdat merged commit 670d1aa into master Nov 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants