[Regression] TF-2528 Fix sort by sender name incorrect #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dab246
changed the title
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3257. |
|
Better indeed! |
tddang-linagora
previously approved these changes
Nov 7, 2024
hoangdat
reviewed
Nov 10, 2024
hoangdat
reviewed
Nov 10, 2024
Done demo.webm |
dab246
force-pushed
the
bugfix/tf-2528-sort-by-sender-name-incorrect
branch
from
2af41f6
to
ad98dbf
Compare
datdang1995
approved these changes
Nov 12, 2024
tddang-linagora
previously approved these changes
Nov 12, 2024
hoangdat
reviewed
Nov 12, 2024
3 tasks
dab246
force-pushed
the
bugfix/tf-2528-sort-by-sender-name-incorrect
branch
from
dbf1954
to
34848f0
Compare
Logsjava.lang.AssertionError: Dart test failed: tests.search.search_email_with_sort_order_test__Should__see__list__email__displayed__by__sort__order__selected__when__search__email__successfully
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
The following TestFailure was thrown running a test:
Expected: '[email protected]'
Actual: '[email protected]'
Which: is different.
Expected: charlotte@ ...
Actual: david@exam ...
^
Differ at offset 0
When the exception was thrown, this was the stack:
#4 SearchRobot.expectEmailListSortedCorrectBySenderAscending (file:///Users/dangdat/Desktop/dev/linagora-master/tmail-flutter/integration_test/robots/search_robot.dart:52:7)
#5 SearchEmailWithSortOrderScenario.execute (file:///Users/dangdat/Desktop/dev/linagora-master/tmail-flutter/integration_test/scenarios/search_email_with_sort_order_scenario.dart:39:23)
<asynchronous suspension>
#6 main.<anonymous closure> (file:///Users/dangdat/Desktop/dev/linagora-master/tmail-flutter/integration_test/tests/search/search_email_with_sort_order_test.dart:32:7)
<asynchronous suspension>
#7 TestBase.runPatrolTest.<anonymous closure> (file:///Users/dangdat/Desktop/dev/linagora-master/tmail-flutter/integration_test/base/test_base.dart:28:7)
<asynchronous suspension>
#8 patrolTest.<anonymous closure> (package:patrol/src/common.dart:136:7)
<asynchronous suspension>
#9 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:183:15)
<asynchronous suspension>
#10 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1017:5)
<asynchronous suspension>
#11 TestWidgetsFlutterBinding._createTestCompletionHandler.<anonymous closure> (package:flutter_test/src/binding.dart:809:12)
<asynchronous suspension>
This was caught by the test expectation on the following line:
file:///Users/dangdat/Desktop/dev/linagora-master/tmail-flutter/integration_test/robots/search_robot.dart line 52
The test description was:
Should see list email displayed by sort order selected when
search email successfully
═════════════════════════════════════════════════════════════════
at pl.leancode.patrol.PatrolJUnitRunner.runDartTest(PatrolJUnitRunner.java:150)
at com.linagora.android.tmail.MainActivityTest.runDartTest(MainActivityTest.java:31) |
hoangdat
reviewed
Nov 13, 2024
hoangdat
previously approved these changes
Nov 13, 2024
dab246
force-pushed
the
bugfix/tf-2528-sort-by-sender-name-incorrect
branch
from
34848f0
to
aa26728
Compare
Remove current docker image then run again will fix it. |
|
tddang-linagora
approved these changes
Nov 14, 2024
hoangdat
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2528
Solution
Email/queryResolved
Screen.Recording.2024-11-06.at.16.42.48.mov
demo-test.webm